[Webkit-unassigned] [Bug 47264] Introduce the device element as an experimental feature

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 28 09:19:32 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=47264





--- Comment #7 from Adam Bergkvist <adam.bergkvist at ericsson.com>  2011-01-28 09:19:32 PST ---
(In reply to comment #6)

> HTML parsing should not be conditional on which features are enabled.  If this line of could should be here, it should be here unconditionally and we should have parser test that demonstrates this change.

Is it possible to remove the end tag requirement without touching the parser code, like you could with the old parser? I guess we still want the device element to be feature guarded?

> #if 0 ?

 38 #if 0
 39 #else
 40 #define StreamDeviceManagerPrivateClassName NullStreamDeviceManagerPrivate
 41 #endif 

The "if 0" was intended has a hint to where platform specific code should go. That line is overwritten when you apply the GTK-specific patch (see https://bugs.webkit.org/show_bug.cgi?id=53264). In this case it forces the usage of the fallback class NullStreamDeviceManagerPrivate. Perhaps it would be better to just use a single #define.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list