[Webkit-unassigned] [Bug 52422] [chromium] More crash in FontFallbackList::determinePitch(const Font* font)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52422


Hironori Bono <hbono at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80034|0                           |1
        is obsolete|                            |
  Attachment #80034|commit-queue?               |
               Flag|                            |
  Attachment #80174|                            |review?
               Flag|                            |




--- Comment #11 from Hironori Bono <hbono at chromium.org>  2011-01-26 00:25:36 PST ---
Created an attachment (id=80174)
 --> (https://bugs.webkit.org/attachment.cgi?id=80174&action=review)
A carpet-bomb approach 3

Greetings,

Thank you for your review and comments.

(In reply to comment #10)
> (From update of attachment 80034 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=80034&action=review
> > Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp:419
> > +    OutputDebugString(logFont->lfFaceName);
> 
> Is this needed?

Oops, this API call is just for debugging and I should have removed it. I have removed this call.

> > Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp:587
> > +    if (dc) {
> > +      GetLastResortFallbackFontProcData procData(this, &description, fallbackFontName);
> > +      EnumFontFamilies(dc, 0, getLastResortFallbackFontProc, reinterpret_cast<LPARAM>(&procData));
> > +      ReleaseDC(0, dc);
> > +
> > +      if (procData.m_fontData)
> > +        return procData.m_fontData;
> > +    }
> 
> Wrong indentation.

Ah, thank you for noticing it. I have fixed the indentation.

Regards,

Hironori Bono

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.