[Webkit-unassigned] [Bug 52422] [chromium] More crash in FontFallbackList::determinePitch(const Font* font)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52422


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80034|review?                     |review-
               Flag|                            |




--- Comment #10 from Kent Tamura <tkent at chromium.org>  2011-01-25 19:24:24 PST ---
(From update of attachment 80034)
View in context: https://bugs.webkit.org/attachment.cgi?id=80034&action=review

I think the change is reasonable.
r- because of a style error.

> Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp:419
> +    OutputDebugString(logFont->lfFaceName);

Is this needed?

> Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp:587
> +    if (dc) {
> +      GetLastResortFallbackFontProcData procData(this, &description, fallbackFontName);
> +      EnumFontFamilies(dc, 0, getLastResortFallbackFontProc, reinterpret_cast<LPARAM>(&procData));
> +      ReleaseDC(0, dc);
> +
> +      if (procData.m_fontData)
> +        return procData.m_fontData;
> +    }

Wrong indentation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.