[Webkit-unassigned] [Bug 51587] [GTK] Remove mandatory Enchant dependency

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51587





--- Comment #14 from Martin Robinson <mrobinson at webkit.org>  2011-01-25 17:41:55 PST ---
(In reply to comment #13)
> If then, how about SpellCheckerEnchant.cpp and SpellCheckerDummy.cpp?
> I'll move some of functions in EditorClient into each files.

Sounds like a good plan, but why not just split out the implementations of the methods of EditorClient into three files:

EditorClient.cpp: for code that is shared
EditorClientEnchant.cpp: for the enchant versions of the spell check methods EditorClientNoSpellChecking.cpp:  (or something similar) for the empty implementation

Perhaps then webkitwebsettings.cpp could just call static methods of the EditorClient to update the spelling dictionary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.