[Webkit-unassigned] [Bug 51587] [GTK] Remove mandatory Enchant dependency

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 25 17:32:45 PST 2011


--- Comment #13 from Ryuan Choi <ryuan.choi at samsung.com>  2011-01-25 17:32:45 PST ---
(In reply to comment #12)
> I've commented with Martin that maybe we could try to avoid of the ifdefs adding a dummy spell checker, and separating the enchant code in a file and the dummy in other file. That way we could make the compile option --enable-enchant instead of removing the spell checking option. If it is disabled we would use the dummy implementation.
> Spell checking is a webkit feature so I think it would be better that solution because it would be more consistent to always have the spell checking option that you can enable or disable, even if that is dummy. And we would avoid the enchant library compilation if we want. Does this make sense to you?

Yes, It looks better.
If then, how about SpellCheckerEnchant.cpp and SpellCheckerDummy.cpp?
I'll move some of functions in EditorClient into each files.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list