[Webkit-unassigned] [Bug 52712] Add a compile-time option to disable WebArchive support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52712





--- Comment #9 from Darin Adler <darin at apple.com>  2011-01-25 11:52:41 PST ---
(From update of attachment 80036)
View in context: https://bugs.webkit.org/attachment.cgi?id=80036&action=review

>> Source/WebKit2/UIProcess/WebFrameProxy.h:113
>>      void getResourceData(WebURL*, PassRefPtr<DataCallback>);
> 
> This functions are mis-named (not the fault of this patch).

They are not. These are calls that asynchronously get data. They have the word get in their names to emphasize that their results are conveyed in a way that is different from a function return value, analogous to how functions with out arguments use the word get.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:991
>  void WebPageProxy::getResourceDataFromFrame(WebFrameProxy* frame, WebURL* resourceURL, PassRefPtr<DataCallback> prpCallback)

This is not a web archive function. I think the conditional is wrong.

> Source/WebKit2/UIProcess/WebPageProxy.h:276
> +#if ENABLE(WEB_ARCHIVE)
>      void getResourceDataFromFrame(WebFrameProxy*, WebURL*, PassRefPtr<DataCallback>);
> +    void getWebArchiveOfFrame(WebFrameProxy*, PassRefPtr<DataCallback>);
> +#endif

Removing these functions will break compilation of WKFrame.cpp for platforms that turn off WEB_ARCHIVE, so this is incomplete.

We won’t conditionalize WKFrame.h since it is an API header intended to be used outside WebKit, so we’ll need to solve that problem.

Perhaps this is why the Qt and GTK builds are broken.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.