[Webkit-unassigned] [Bug 52712] Add a compile-time option to disable WebArchive support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52712


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80036|review?                     |review+
               Flag|                            |




--- Comment #8 from Adam Barth <abarth at webkit.org>  2011-01-25 10:58:49 PST ---
(From update of attachment 80036)
View in context: https://bugs.webkit.org/attachment.cgi?id=80036&action=review

Looks reasonable to me.  Certainly if WebArchive were added today, it would have an ifdef.  I can't verify that all the placement details are correct, but it's plausible.

> Source/WebCore/ChangeLog:3
> +

You've got an extra line here.

> Source/WebCore/WebCore.gypi:-2096
> -            'loader/archive/cf/LegacyWebArchive.cpp',
> -            'loader/archive/cf/LegacyWebArchive.h',
> -            'loader/archive/cf/LegacyWebArchiveMac.mm',
> -            'loader/archive/Archive.h',
> -            'loader/archive/ArchiveFactory.cpp',
> -            'loader/archive/ArchiveFactory.h',
> -            'loader/archive/ArchiveResource.cpp',
> -            'loader/archive/ArchiveResource.h',
> -            'loader/archive/ArchiveResourceCollection.cpp',
> -            'loader/archive/ArchiveResourceCollection.h',

The gypi should list all files in the project, regardless of whether they're used by Chromium.

> Source/WebKit2/UIProcess/WebFrameProxy.h:113
>      void getWebArchive(PassRefPtr<DataCallback>);
>      void getMainResourceData(PassRefPtr<DataCallback>);
>      void getResourceData(WebURL*, PassRefPtr<DataCallback>);

This functions are mis-named (not the fault of this patch).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.