[Webkit-unassigned] [Bug 53012] IndexedDatabase methods should not take arguments of type OptionsObject

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53012





--- Comment #9 from Andrei Popescu <andreip at google.com>  2011-01-24 10:55:07 PST ---
(In reply to comment #8)
> (From update of attachment 79934 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79934&action=review
> 
> LGTM
> 
> > Source/WebCore/bindings/v8/V8Binding.h:35
> > +#include "DOMStringList.h"
> 
> Just forward declare here.
> 

Done.

> >> Source/WebCore/storage/IDBDatabase.cpp:113
> >> +    if (timeout > std::numeric_limits<unsigned long>::max())
> > 
> > It still feels fishy. It seems to me this condition can never be true?
> 
> It really doesn't matter either way...

I will remove that check then and land.

Thanks all for the reviews!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.