[Webkit-unassigned] [Bug 53012] IndexedDatabase methods should not take arguments of type OptionsObject

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53012





--- Comment #8 from Jeremy Orlow <jorlow at chromium.org>  2011-01-24 10:50:02 PST ---
(From update of attachment 79934)
View in context: https://bugs.webkit.org/attachment.cgi?id=79934&action=review

LGTM

> Source/WebCore/bindings/v8/V8Binding.h:35
> +#include "DOMStringList.h"

Just forward declare here.

>> Source/WebCore/storage/IDBDatabase.cpp:113
>> +    if (timeout > std::numeric_limits<unsigned long>::max())
> 
> It still feels fishy. It seems to me this condition can never be true?

It really doesn't matter either way...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.