[Webkit-unassigned] [Bug 38982] [Chromium] WebKit API: Support icon loading for <input type=file>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38982


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79703|review+, commit-queue-      |
               Flag|                            |




--- Comment #25 from Kent Tamura <tkent at chromium.org>  2011-01-24 01:17:49 PST ---
(From update of attachment 79703)
Thank you for reviewing!!!

Landed with the following fixes: http://trac.webkit.org/changeset/76491


View in context: https://bugs.webkit.org/attachment.cgi?id=79703&action=review

>> Source/WebKit/chromium/src/WebIconLoadingCompletionImpl.cpp:52
>> +        RefPtr<WebCore::Image> image = WebCore::BitmapImage::create();
> 
> nit: I recommend a 'using namespace WebCore' up top, so you can ditch the WebCore::

Done.

>> Source/WebKit/chromium/src/WebIconLoadingCompletionImpl.h:47
>> +    ~WebIconLoadingCompletionImpl();
> 
> nit: I think the destructor here can be private.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.