[Webkit-unassigned] [Bug 38982] [Chromium] WebKit API: Support icon loading for <input type=file>
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 21 09:46:17 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=38982
Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79703|review? |review+, commit-queue-
Flag| |
--- Comment #24 from Darin Fisher (:fishd, Google) <fishd at chromium.org> 2011-01-21 09:46:17 PST ---
(From update of attachment 79703)
View in context: https://bugs.webkit.org/attachment.cgi?id=79703&action=review
> Source/WebKit/chromium/src/WebIconLoadingCompletionImpl.cpp:52
> + RefPtr<WebCore::Image> image = WebCore::BitmapImage::create();
nit: I recommend a 'using namespace WebCore' up top, so you can ditch the WebCore::
> Source/WebKit/chromium/src/WebIconLoadingCompletionImpl.h:47
> + ~WebIconLoadingCompletionImpl();
nit: I think the destructor here can be private.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list