[Webkit-unassigned] [Bug 52945] crash @ WebCore::ResourceLoader::didCancel(WebCore::ResourceError const &)

Sat Jan 22 01:43:47 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=52945

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79822|review?                     |review-
               Flag|                            |

--- Comment #6 from Alexey Proskuryakov <ap at webkit.org>  2011-01-22 01:43:47 PST ---
(From update of attachment 79822)
r- for lack of tests and for tabs.

This looks very much like some bug I investigated recently, so I'd like to think about this in depth. Generally, early returns on null checks should be added very cautiously, because it's hard to tell which class invariants get violated by not running the remainder of the function, and you end up investigating much more mysterious bugs a few months later.

Thanks for posting a lot of detail about your investigation, it's really helpful.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.