[Webkit-unassigned] [Bug 52945] crash @ WebCore::ResourceLoader::didCancel(WebCore::ResourceError const &)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52945





--- Comment #5 from Adam Barth <abarth at webkit.org>  2011-01-21 22:05:20 PST ---
(From update of attachment 79822)
View in context: https://bugs.webkit.org/attachment.cgi?id=79822&action=review

> Source/WebCore/ChangeLog:9
> +        Covered by Chromium browser_tests.

It's much better if we can test changes using only things in webkit.org.  That way regressions don't surprise use down the road.  We've talked about trying to make a layout test for this change.  It's probably worthwhile to explain what you tried here and what trouble you ran into.

> Source/WebCore/loader/ResourceLoader.cpp:84
>      ASSERT(!m_reachedTerminalState);
> +    if (m_reachedTerminalState)
> +        return;

Generally we don't have both an assert and code to handle the opposite of the assert.  If this case occurs, that means the assert is wrong and should be removed.  However, we might try to look at "svn blame" to understand why this assert was added.  It's a clue telling us that something else might be wrong.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.