[Webkit-unassigned] [Bug 52867] New: OwnArraryPtr.h should inclue OwnPtrCommon.h or it shouldn't call DeleteOwnedPtr

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52867

           Summary: OwnArraryPtr.h should inclue OwnPtrCommon.h or it
                    shouldn't call DeleteOwnedPtr
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: mjs at apple.com, darin at apple.com


Chromium clang build is failing with the following error:

> In file included from
> third_party/WebKit/Source/WebCore/html/HTMLFrameSetElement.h:27:
> third_party/WebKit/Source/JavaScriptCore/wtf/OwnArrayPtr.h:123:5:error:
> use of undeclared identifier 'deleteOwnedPtr'
>    deleteOwnedPtr(oldPtr);
>    ^
> third_party/WebKit/Source/WebCore/html/HTMLFrameSetElement.cpp:78:26:
> note: in instantiation of member function
> 'WTF::OwnArrayPtr<WebCore::Length>::set' requested here
>            m_rowLengths.set(newLengthArray(attr->value().string(),
> m_totalRows));
>                         ^
> 1 error generated.

The problem is that OwnArrayPtr::set calls deleteOwnedPtr but doesn't include OwnPtrCommon.h.  We should either include the header or should call deleteOwnedArrayPtr.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.