[Webkit-unassigned] [Bug 51155] [GTK] Menulist text often collides with separator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51155


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79323|review?                     |
               Flag|                            |




--- Comment #8 from Martin Robinson <mrobinson at webkit.org>  2011-01-20 09:08:49 PST ---
(From update of attachment 79323)
View in context: https://bugs.webkit.org/attachment.cgi?id=79323&action=review

>> Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:411
>> +
> 
> hmm I didn't know that style property, we are not checking it, so I guess we are assuming that if the combobox widget doesn't have a separator in its children widget list it's because appears-as-list = 1

Yep. We have to have the child widgets anyway, to ensure proper rendering, so we just check there. This was inspired by the Mozilla code.

>> Source/WebCore/platform/gtk/WidgetRenderingContext.cpp:208
>> +                    static_cast<GtkArrowType>(arrowDirection), TRUE, paintRect.x, paintRect.y, paintRect.width, paintRect.height);
> 
> You are using m_paintRect here instead of paintRect

Very right. I had fixed this locally, but I should upload a new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.