[Webkit-unassigned] [Bug 51155] [GTK] Menulist text often collides with separator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51155





--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-01-20 00:45:23 PST ---
(From update of attachment 79323)
View in context: https://bugs.webkit.org/attachment.cgi?id=79323&action=review

Great patch!, I've tried it and it works perfectly with the gtk+ default theme.

> Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:411
> +

hmm I didn't know that style property, we are not checking it, so I guess we are assuming that if the combobox widget doesn't have a separator in its children widget list it's because appears-as-list = 1

> Source/WebCore/platform/gtk/WidgetRenderingContext.cpp:208
> +    GdkRectangle paintRect = { m_paintRect.x + rect.x(), m_paintRect.y + rect.y(), rect.width(), rect.height() };
> +    gtk_paint_arrow(gtk_widget_get_style(widget), m_target, stateType, shadowType, &m_paintRect, widget, detail,
> +                    static_cast<GtkArrowType>(arrowDirection), TRUE, paintRect.x, paintRect.y, paintRect.width, paintRect.height);

You are using m_paintRect here instead of paintRect

> Source/WebCore/platform/gtk/WidgetRenderingContext.cpp:215
> +    GdkRectangle paintRect = { m_paintRect.x + rect.x(), m_paintRect.y + rect.y(), rect.width(), rect.height() };
> +    gtk_paint_vline(gtk_widget_get_style(widget), m_target, stateType, &m_paintRect, widget, detail,
> +                    paintRect.y, paintRect.y + paintRect.height, paintRect.x);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.