[Webkit-unassigned] [Bug 52742] Stop instantiating legacy editing positions in FocusController::advanceFocusInDocumentOrder

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 20 07:35:05 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=52742





--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2011-01-20 07:35:04 PST ---
(In reply to comment #2)
> I've some doubts whether the right thing to do would be just to call firstPositionInNode(node) instead of your suggestion, but then I've tried it out and run the unit and layout tests and it seems everything is fine with firstPositionInOrBeforeNode(node).

Calling firstPositionInNode won't make any sense if editing can ignore contents for the node.  e.g. if node was br, img, textarea, etc... it doesn't make any sense to have a position inside that node.  Is there any guarantee that node is always a container and the contents are not ignored by editing?  That's a requirement for us to be calling firstPositionInNode.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list