[Webkit-unassigned] [Bug 52742] Stop instantiating legacy editing positions in FocusController::advanceFocusInDocumentOrder

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52742





--- Comment #2 from Mario Sanchez Prada <msanchez at igalia.com>  2011-01-20 03:01:42 PST ---
(In reply to comment #1)
> I think the right thing to do here is to call firstPositionInOrBeforeNode.
> 
> This function produces a position [node, 0] when node can have children for editing (div, blockquote, span, etc...) and before node when node can't have children for editing (br, img, etc...).
> 
> Could someone from GTK comment on whether this is right behavior or not?

I've some doubts whether the right thing to do would be just to call firstPositionInNode(node) instead of your suggestion, but then I've tried it out and run the unit and layout tests and it seems everything is fine with firstPositionInOrBeforeNode(node).

So guess you're right and thus that your patch is the right way to go.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.