[Webkit-unassigned] [Bug 49334] Implement Default Ruby Overhang Behavior

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49334





--- Comment #11 from Eric Mader <emader at apple.com>  2011-01-19 08:59:39 PST ---
(In reply to comment #8)
> (From update of attachment 78066 [details])
> Include changes in a patch please, rather than just posting them in comments.  It's easier to comment on the code if it's in the pretty-printed form.

OK. I was in a time crunch and this was faster than re-generating the patch. I'll take the time to do it right from now on.

> I still think you need to cap the amount you're willing to overhang.

OK. I can cap it based on the point size of the base text without too  much trouble, I think.

> Also, the change to shrink the font-size to 50% has nothing to do with this bug, and we should just do that in a separate change.

My thinking was that changing the font-size to 50% reduced the cases where overhang would be required, but I'm happy to make this a separate change, especially since I also need to special-case the enforcement of the minimum point size for ruby text.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.