[Webkit-unassigned] [Bug 49334] Implement Default Ruby Overhang Behavior

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49334





--- Comment #10 from Eric Mader <emader at apple.com>  2011-01-19 08:55:40 PST ---
(In reply to comment #9)
> I also had this question in my previous review:
> 
> "(1) What are we supposed to do about overhang at the start of a line? At the end of the line?  Does the Ruby traditionally spill out above the top or below the bottom of the line in vertical text in that case?  The current patch is going to let Ruby overhang at the start and end of lines.  Is that what we want?  It's pretty easy to detect if the overhang can fit or not, since you have all that info in findNextLineBreak."

The spec says that the ruby text should not hang into the top or bottom margins. My code checks to see if the ruby block is first on the line and will not permit overhang in that case (by passing 0 as the address of the last block).

To handle the bottom margin, my code does not take any overhang into account when deciding whether or not the ruby block fits on the line. The idea is that if the ruby text will not fit on the line, then the text it would overhang won't fit either.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.