[Webkit-unassigned] [Bug 51664] Refactoring: Extract RoundedIntRect class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51664





--- Comment #22 from Antonio Gomes <tonikitoo at webkit.org>  2011-01-18 08:39:41 PST ---
(From update of attachment 79270)
View in context: https://bugs.webkit.org/attachment.cgi?id=79270&action=review

Nice work!

> Source/WebCore/platform/graphics/GraphicsContext.cpp:546
> +    path.addRoundedRect(rect.rect(), rect.radii().topLeft(), rect.radii().topRight(), rect.radii().bottomLeft(), rect.radii().bottomRight());

It would nice if Path::addRoundedRect get the "const RoundedIntRect&" as parameter, and extract the values from there.

Caller sites would look better, maybe.

> Source/WebCore/platform/graphics/GraphicsContext.cpp:556
> +    path.addRoundedRect(rect.rect(), rect.radii().topLeft(), rect.radii().topRight(), rect.radii().bottomLeft(), rect.radii().bottomRight());

Would affect here too.

> Source/WebCore/platform/graphics/RoundedIntRect.h:87
> +    void move(const IntSize size) { m_rect.move(size); }

const IntSize&

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.