[Webkit-unassigned] [Bug 51664] Refactoring: Extract RoundedIntRect class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 18 05:56:48 PST 2011


--- Comment #21 from MORITA Hajime <morrita at google.com>  2011-01-18 05:56:47 PST ---
Hi Simon, I found pixel test failures and other redness on the buildbot so rolled the last patch out.
Now I uploaded revised one. Would you able to take it again?

This addresses following isssues:

- Added missing file for WebCore.vcproj and GNUMakefile.am
- Added missing null check (which caused a crash on some release builds) in paintBoxShadow().
   Extracting includeLogicalEdges() causes null-access.
- Shadow radii computation was broken, again in paintBoxSadow(), which causes
   pixel test failures with 0 tolerance. So I fixed it and now they passes.

Thanks in advance.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list