[Webkit-unassigned] [Bug 50657] Attribute lost with Flash plugin without mime type set

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50657





--- Comment #12 from Andy Estes <aestes at apple.com>  2011-01-11 15:07:22 PST ---
(From update of attachment 78531)
View in context: https://bugs.webkit.org/attachment.cgi?id=78531&action=review

> Source/WebCore/loader/FrameLoader.cpp:972
> +#if !PLATFORM(MAC) && !PLATFORM(CHROMIUM) && !PLATFORM(EFL) // Mac has no PluginDatabase, nor does Chromium or EFL
> +    if (mimeType.isEmpty())
> +        mimeType = PluginDatabase::installedPlugins()->MIMETypeForExtension(extension);
> +#endif

Shouldn't this code be in the relevant platforms' implementations of MIMETypeRegistry so as to not litter cross-platform code with ifdefs? I know you're probably just following a convention already established in this method, but it still seems ugly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.