[Webkit-unassigned] [Bug 50657] Attribute lost with Flash plugin without mime type set

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50657





--- Comment #13 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk>  2011-01-11 15:17:32 PST ---
(In reply to comment #12)
> (From update of attachment 78531 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=78531&action=review
> 
> > Source/WebCore/loader/FrameLoader.cpp:972
> > +#if !PLATFORM(MAC) && !PLATFORM(CHROMIUM) && !PLATFORM(EFL) // Mac has no PluginDatabase, nor does Chromium or EFL
> > +    if (mimeType.isEmpty())
> > +        mimeType = PluginDatabase::installedPlugins()->MIMETypeForExtension(extension);
> > +#endif
> 
> Shouldn't this code be in the relevant platforms' implementations of MIMETypeRegistry so as to not litter cross-platform code with ifdefs? I know you're probably just following a convention already established in this method, but it still seems ugly.

The ifdef are only there because MAC, Chromium and ELF port have decided not to use the plugin database (we can only blame those port). Also, doing it in the paltform specific MIME database implementation is complex and forces plug-ins to be loaded at start instead of on-demand. This was my conclusion after trying it in GTK port. It fully convinced me that this approach is the right one, and it fixes bug for many port at once.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.