[Webkit-unassigned] [Bug 45186] Use the Windows thread pool instead of an extra thread for FastMalloc scavenging

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45186





--- Comment #5 from Adam Roben (aroben) <aroben at apple.com>  2011-01-11 07:35:35 PST ---
(From update of attachment 78526)
View in context: https://bugs.webkit.org/attachment.cgi?id=78526&action=review

>> Source/JavaScriptCore/wtf/FastMalloc.cpp:1566
>> +    }
> 
> I think it would be a lot better if we followed the libdispatch implementation. periodicScavenge just performs a single scavenge, then waits for the timer to fire again (or stops the timer if no more scavenging is needed). That way we don't tie up a worker thread while we sleep and block.

Patrick pointed out that I was misreading the patch and that this code isn't executing on Windows anymore. However, runScavenge still includes a sleep() call, which I don't think we should be doing on the worker thread. We should use a timer queue timer so that the waiting happens on a thread pool wait thread. Then when the timer fires, we should just scavenge immediately.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.