[Webkit-unassigned] [Bug 50901] Add remote zip file handling to webkitpy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50901





--- Comment #23 from James Kozianski <koz at chromium.org>  2011-01-06 20:44:19 PST ---
(In reply to comment #22)
> (From update of attachment 78201 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=78201&action=review
> 
> > Tools/Scripts/webkitpy/common/system/filesystem.py:162
> > +    def extract(self, zip, filename, path):
> 
> As discussed in #webkit, extract doesn't really belong in FileSystem. For the sake of testability, passing in the ZipFile (or a lazy-loading wrapper) to the ZipFileSet constructor is cleaner.

Yep. I used your suggestion of passing in the constructor.

> 
> > Tools/Scripts/webkitpy/common/system/filesystem_mock.py:60
> > +        return os.path.join(*comps)
> 
> The mock filesystem hardcodes / as the separator, so it should keep using '/'.join(comps) as its join() implementation.

I've changed it to use os.path.join() but then to substitute back to using '/' because os.path.join() collapses slashes, which '/'.join() doesn't.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.