[Webkit-unassigned] [Bug 50901] Add remote zip file handling to webkitpy.

Thu Jan 6 19:07:45 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=50901

Mihai Parparita <mihaip at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #78201|review?                     |review-
               Flag|                            |

--- Comment #22 from Mihai Parparita <mihaip at chromium.org>  2011-01-06 19:07:45 PST ---
(From update of attachment 78201)
View in context: https://bugs.webkit.org/attachment.cgi?id=78201&action=review

> Tools/Scripts/webkitpy/common/system/filesystem.py:162
> +    def extract(self, zip, filename, path):

As discussed in #webkit, extract doesn't really belong in FileSystem. For the sake of testability, passing in the ZipFile (or a lazy-loading wrapper) to the ZipFileSet constructor is cleaner.

> Tools/Scripts/webkitpy/common/system/filesystem_mock.py:60
> +        return os.path.join(*comps)

The mock filesystem hardcodes / as the separator, so it should keep using '/'.join(comps) as its join() implementation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.