[Webkit-unassigned] [Bug 48459] Glyphs in vertical text tests are rotated 90 degrees clockwise on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48459





--- Comment #12 from Koan-Sin Tan <koansin.tan at gmail.com>  2011-01-06 16:38:40 PST ---
(In reply to comment #11)
> (From update of attachment 77702 [details])
> If I'm understanding this correctly, you're just putting @ in front of the family name to get the fonts hashed separately to trip the broken ideographic font code path.  That isn't really supporting vertical text.  Punctuation glyphs won't be correct for example.
> 

First, thanks for the great work you did for writing modes.

What amazed us when my colleague was trying various approaches on Windows is that @ works like a charm. Punctuation glyphs work really correctly. That's why we use it finally. Please take a look at 

http://www.flickr.com/photos/burorly/5308587584/in/set-72157625585506341/

> I would prefer orientation just be part of the constructed hash key rather than hacking the family name.  We have to do this with bold and oblique already, so I think that's a better approach than hacking the family name.
> 

OK, We'l try that. But please do consider that @ can nearly all the jobs

> Even once you do this, though, you're only sort of supporting vertical text here.  The simple code path is using the broken ideographic font code, which won't really use vertical glyphs from a font with vertical tables (like punctuation glyphs), and the complex code path (that uses Uniscribe) isn't doing anything either.

I don't know anything the complex code path. But what surprised us is that,  with '@', we got less broken fonts. E.g., kaiu.ttf (DFKai-SB,標楷體), which doesn't have any vertical metrics (vhea, vmtx, etc.) so it will be in broken font path in WebKit OS X,does look right with '@'.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.