[Webkit-unassigned] [Bug 48459] Glyphs in vertical text tests are rotated 90 degrees clockwise on Windows

Thu Jan 6 15:28:28 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=48459

Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77702|review?                     |review-
               Flag|                            |

--- Comment #11 from Dave Hyatt <hyatt at apple.com>  2011-01-06 15:28:27 PST ---
(From update of attachment 77702)
If I'm understanding this correctly, you're just putting @ in front of the family name to get the fonts hashed separately to trip the broken ideographic font code path.  That isn't really supporting vertical text.  Punctuation glyphs won't be correct for example.

I would prefer orientation just be part of the constructed hash key rather than hacking the family name.  We have to do this with bold and oblique already, so I think that's a better approach than hacking the family name.

Even once you do this, though, you're only sort of supporting vertical text here.  The simple code path is using the broken ideographic font code, which won't really use vertical glyphs from a font with vertical tables (like punctuation glyphs), and the complex code path (that uses Uniscribe) isn't doing anything either.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.