[Webkit-unassigned] [Bug 50901] Add remote zip file handling to webkitpy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50901





--- Comment #8 from Eric Seidel <eric at webkit.org>  2011-01-06 13:27:33 PST ---
(From update of attachment 77865)
View in context: https://bugs.webkit.org/attachment.cgi?id=77865&action=review

You could just make this a new module common.fileset.  YOu could also just slap this all into one file common/fileset.py.  I'm not sure which is cleaner.  Making it a module is better long-term if we plan to expand on this.

> Tools/Scripts/webkitpy/common/directoryfileset_unittest.py:33
> +class DirectoryFileSetTest(unittest.TestCase):

Seems we should test the whole api here, no?

> Tools/Scripts/webkitpy/common/net/zipfileset.py:63
> +class FileSetFileHandle(object):

Since this is used by more than one file seems it should be in its own file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.