[Webkit-unassigned] [Bug 50901] Add remote zip file handling to webkitpy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50901





--- Comment #7 from Eric Seidel <eric at webkit.org>  2011-01-06 13:24:53 PST ---
(From update of attachment 77865)
View in context: https://bugs.webkit.org/attachment.cgi?id=77865&action=review

> Tools/Scripts/webkitpy/common/directoryfileset_unittest.py:51
> +

two blank lines i believe.

> Tools/Scripts/webkitpy/common/directoryfileset_unittest.py:53
> +if __name__ == '__main__':
> +    unittest.main()

I generally omit these since the way we do imports makes it impossible to run these by hand anywa.

> Tools/Scripts/webkitpy/common/net/zipfileset.py:1
> +#!/usr/bin/env python

Please omit.

> Tools/Scripts/webkitpy/common/net/zipfileset.py:80
> +        if filename is None:
> +            self._fileset.extract(self._filename, path)

I would have early returned here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.