[Webkit-unassigned] [Bug 51874] [GTK] Port slider painting to GtkStyleContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51874





--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2011-01-05 12:24:14 PST ---
(In reply to comment #5)
> Created an attachment (id=78026)
 --> (https://bugs.webkit.org/attachment.cgi?id=78026&action=review) [details]
> Patch moving focus width and focus pad outside of the slider rect

This updated version of the patch has a few changes:
1. Focus width and focus padding are now drawn outside the slider rect, which makes calculating the size of slides pieces much more straight-forward. This is perfectly valid as long as you let WebCore know via adjustRepaintRect, I think.
2. Use NULL as the sentinel for calls to gtk_style_context_get_style. Zero doesn't produce a warnings, but can lead to crashes on 64-bit machines. Thus we should always use NULL.
3. Remove the static_casts wrapping gktTextDirection calls. They are no longer needed.

Let me know if I've futzed anything up too badly! :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.