[Webkit-unassigned] [Bug 51874] [GTK] Port slider painting to GtkStyleContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51874





--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-01-07 01:22:17 PST ---
(In reply to comment #7)
> (In reply to comment #5)
> > Created an attachment (id=78026)
 --> (https://bugs.webkit.org/attachment.cgi?id=78026&action=review) [details] [details]
> > Patch moving focus width and focus pad outside of the slider rect
> 
> This updated version of the patch has a few changes:
> 1. Focus width and focus padding are now drawn outside the slider rect, which makes calculating the size of slides pieces much more straight-forward. This is perfectly valid as long as you let WebCore know via adjustRepaintRect, I think.

Yes, it works. 

> 2. Use NULL as the sentinel for calls to gtk_style_context_get_style. Zero doesn't produce a warnings, but can lead to crashes on 64-bit machines. Thus we should always use NULL.

Great, never liked using 0 instead of NULL, at least there's an exception here :-)

> 3. Remove the static_casts wrapping gktTextDirection calls. They are no longer needed.

Right.

> Let me know if I've futzed anything up too badly! :)

The only problem is that the slider thumb is painted outside the slider track, you still need to take into account the trough border to make the thumb fit into the slider track.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.