[Webkit-unassigned] [Bug 48781] Add a resourceload delegate method to query if WebCore should paint the default broken image for failed images.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48781


Yongjun Zhang <yongjun_zhang at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73268|0                           |1
        is obsolete|                            |
  Attachment #77846|                            |review?
               Flag|                            |




--- Comment #13 from Yongjun Zhang <yongjun_zhang at apple.com>  2011-01-03 14:10:40 PST ---
Created an attachment (id=77846)
 --> (https://bugs.webkit.org/attachment.cgi?id=77846&action=review)
New patch addressing comments.

Thanks, for the review.  Here is the new patch.

Changes:

1. added default implementation for FrameLoaderClient::shouldPaintBrokenImage, so that I don't need to touch other WebKit ports.
2. set m_shouldPaintBrokenImage in CachedImage::checkShouldPaintBrokenImage instead of the call site.
3. moved webView:shouldPaintBrokenImage:(NSURL*)imageURL to WebResourceLoadDelegatePrivate.
4. removed image errorcode argument from FrameLoaderClient::shouldPaintBrokenImage and the delegate method, since the developer asked for this feature mainly cared about the URL of the failed image, no the error code.  I will open another bug if they really need it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.