[Webkit-unassigned] [Bug 51818] GeolocationPositionCache should not use ScriptExecutionContext::Task

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51818


Steve Block <steveblock at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77826|                            |commit-queue-
               Flag|                            |




--- Comment #4 from Steve Block <steveblock at google.com>  2011-01-03 12:51:00 PST ---
(From update of attachment 77826)
View in context: https://bugs.webkit.org/attachment.cgi?id=77826&action=review

>> WebCore/fileapi/FileThread.h:58
>> +    class FileTask : public Task {
> 
> Does this really need to be renamed? You could just say this:
> 
>     class Task : public WTF::Task
> 
> That would make the patch smaller, but I guess could be a bit confusing. With the name FileTask it seems it could be made a non-member.

OK, I'll leave the name unchanged to minimise the size of the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.