[Webkit-unassigned] [Bug 55301] [REGRESSION r79784?] Can't open Network panel in the inspector (assertion failed in layout)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 27 20:40:51 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=55301





--- Comment #12 from Rik Cabanier <cabanier at gmail.com>  2011-02-27 20:40:51 PST ---
(In reply to comment #10)
> Layout tests can (and are) run in debug, which is why so many bots are having trouble with the previous patch.
> 
> Why is it valid to remove this ASSERT()?  Did it serve no purpose before?  It looks like the table layout code was using setRawValue() when it wanted to directly set a value (and not go through this path), why did you change those to setValue()?

In response to question 1 and 2:
the assert used to test that you didn't call setvalue with a percent value but SetRawValue. I guess this was done to make sure that you knew what your are doing (which seems hacky).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list