[Webkit-unassigned] [Bug 55301] [REGRESSION r79784?] Can't open Network panel in the inspector (assertion failed in layout)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 27 20:29:27 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=55301
--- Comment #11 from Rik Cabanier <cabanier at gmail.com> 2011-02-27 20:29:26 PST ---
(In reply to comment #10)
> Layout tests can (and are) run in debug, which is why so many bots are having trouble with the previous patch.
>
> Why is it valid to remove this ASSERT()? Did it serve no purpose before? It looks like the table layout code was using setRawValue() when it wanted to directly set a value (and not go through this path), why did you change those to setValue()?
I did that by request of dhyatt since at first glance there was no more difference between setValue and setRawValue and he thought it was less confusing than having 2 almost identical calls.
These changes are definitely a work in progress as the intent is to move everything to float values at which point all the assert can go away.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list