[Webkit-unassigned] [Bug 54942] In layout tests, iframe's onload handler should not use script function defined after the iframe

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54942





--- Comment #13 from Xianzhu Wang <wangxianzhu at google.com>  2011-02-26 18:10:24 PST ---
(From update of attachment 83790)
View in context: https://bugs.webkit.org/attachment.cgi?id=83790&action=review

>> LayoutTests/editing/execCommand/find-after-replace.html:7
>> +<iframe src="../resources/contenteditable-iframe-src.html"></iframe>
> 
> Rather than moving the runTest to the body's onload, why not just move the script block above the iframe? Same question on a few other tests.

This is to avoid expectation changes, especially for the tests that have platform rebaselines.

>> LayoutTests/fast/frames/viewsource-plain-text-tags.html:36
>> +<hr>
> 
> This used to be <hr><iframe><hr><div> and now it is <hr><div><hr><iframe>. I'm surprised there is no change in the expectations. Does it really pass? Perhaps it is disabled on the port where you ran tests?

I was also surprised then I found this test just overwrites the whole text result with "document.open(); document.write(resultText); document.close()", so the text dump isn't affected by change of sequence of the div, hr and iframe.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.