[Webkit-unassigned] [Bug 54942] In layout tests, iframe's onload handler should not use script function defined after the iframe

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54942





--- Comment #12 from Tony Gentilcore <tonyg at chromium.org>  2011-02-25 08:58:41 PST ---
(From update of attachment 83790)
This is awesome work! A couple of questions below. This patch is large and I want to make sure we don't accidentally change any tests so that they don't test what they were originally designed to test.

View in context: https://bugs.webkit.org/attachment.cgi?id=83790&action=review

> LayoutTests/editing/execCommand/find-after-replace.html:7
> +<iframe src="../resources/contenteditable-iframe-src.html"></iframe>

Rather than moving the runTest to the body's onload, why not just move the script block above the iframe? Same question on a few other tests.

> LayoutTests/fast/frames/viewsource-plain-text-tags.html:36
> +<hr>

This used to be <hr><iframe><hr><div> and now it is <hr><div><hr><iframe>. I'm surprised there is no change in the expectations. Does it really pass? Perhaps it is disabled on the port where you ran tests?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.