[Webkit-unassigned] [Bug 54199] [GTK] Implement NativeWebKeyboard and WebContext classes for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54199





--- Comment #9 from Alejandro G. Castro <alex at igalia.com>  2011-02-25 09:17:55 PST ---
(In reply to comment #8)
> (From update of attachment 83802 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83802&action=review
> 
> > Source/WebKit2/Shared/gtk/NativeWebKeyboardEventGtk.cpp:39
> > +static inline GdkEventKey* copyGdkEventKey(const GdkEventKey* event)
> > +{
> > +    return reinterpret_cast<GdkEventKey*>(gdk_event_copy(reinterpret_cast<const GdkEvent*>(event)));
> > +}
> 
> I think this may be uneeded. See below.
> 
> > Source/WebKit2/Shared/gtk/NativeWebKeyboardEventGtk.cpp:43
> > +    , m_nativeEvent(copyGdkEventKey(event))
> 
> Could you just have these accept a GdkEvent* and then just do:
> 

Yeah, I thought about it but then we will have to change the calls to do the reinterpret_cast, this seemed a better option leaving here all the casts.

> , m_nativeEvent(gdk_even_copy(event)->key)
> 
> > Source/WebKit2/Shared/gtk/NativeWebKeyboardEventGtk.cpp:49
> > +    , m_nativeEvent(copyGdkEventKey(event.nativeEvent()))
> 
> Here I guess you can do:
> gdk_event_copy(reinterpret_cast<const GdkEvent*>(event.nativeEvent())->key)
> 
> > Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:47
> > +    // FIXME: Implement.
> > +    return "";
> 
> Let's fill this in with the default we use now.

Ok, I'll do it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.