[Webkit-unassigned] [Bug 54199] [GTK] Implement NativeWebKeyboard and WebContext classes for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54199





--- Comment #8 from Martin Robinson <mrobinson at webkit.org>  2011-02-25 09:07:07 PST ---
(From update of attachment 83802)
View in context: https://bugs.webkit.org/attachment.cgi?id=83802&action=review

> Source/WebKit2/Shared/gtk/NativeWebKeyboardEventGtk.cpp:39
> +static inline GdkEventKey* copyGdkEventKey(const GdkEventKey* event)
> +{
> +    return reinterpret_cast<GdkEventKey*>(gdk_event_copy(reinterpret_cast<const GdkEvent*>(event)));
> +}

I think this may be uneeded. See below.

> Source/WebKit2/Shared/gtk/NativeWebKeyboardEventGtk.cpp:43
> +    , m_nativeEvent(copyGdkEventKey(event))

Could you just have these accept a GdkEvent* and then just do:

, m_nativeEvent(gdk_even_copy(event)->key)

> Source/WebKit2/Shared/gtk/NativeWebKeyboardEventGtk.cpp:49
> +    , m_nativeEvent(copyGdkEventKey(event.nativeEvent()))

Here I guess you can do:
gdk_event_copy(reinterpret_cast<const GdkEvent*>(event.nativeEvent())->key)

> Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:47
> +    // FIXME: Implement.
> +    return "";

Let's fill this in with the default we use now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.