[Webkit-unassigned] [Bug 54807] Always explicitly use "signed" keyword to declare signed bitfields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54807





--- Comment #26 from Yong Li <yong.li.webkit at gmail.com>  2011-02-23 15:07:48 PST ---
(In reply to comment #25)
> (From update of attachment 83495 [details])
> These look fine to me, although given that these places are likely size-sensitive, I would add the COMPILE_ASSERT lines (as they should be easy to add).  The only tricky part there is that that might make landing harder if other compilers fail those checks.
> 
> The cpp.py change needs a test case.
> 
> Maybe you want to do these in separate patches?  r- for the lackof the cpp.py test case.

I didn't even noticed cpp.py file. will add a test case

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.