[Webkit-unassigned] [Bug 54807] Always explicitly use "signed" keyword to declare signed bitfields

Wed Feb 23 15:05:41 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=54807

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83495|review?                     |review-
               Flag|                            |

--- Comment #25 from Eric Seidel <eric at webkit.org>  2011-02-23 15:05:41 PST ---
(From update of attachment 83495)
These look fine to me, although given that these places are likely size-sensitive, I would add the COMPILE_ASSERT lines (as they should be easy to add).  The only tricky part there is that that might make landing harder if other compilers fail those checks.

The cpp.py change needs a test case.

Maybe you want to do these in separate patches?  r- for the lackof the cpp.py test case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.