[Webkit-unassigned] [Bug 54739] [Qt] Add a Method to QWebHistory to let the browser add items to the tab's history

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54739


Benjamin Poulain <benjamin.poulain at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82940|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from Benjamin Poulain <benjamin.poulain at nokia.com>  2011-02-23 03:47:42 PST ---
(From update of attachment 82940)
View in context: https://bugs.webkit.org/attachment.cgi?id=82940&action=review

And this needs good autotest coverage.

> WebKit/qt/Api/qwebhistory.cpp:400
> +  Adds an item to the history.

This is not good enough documentation. The doc also has to mention what are the argument for example.

> WebKit/qt/Api/qwebhistory.cpp:402
> +void QWebHistory::addItem(QString &url, QString &title, double lastVisited)

This should be ref-to-const for url and title.
The type for lastVisited is just mirroring WebKit internal, this is not good for Qt APIs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.