[Webkit-unassigned] [Bug 54739] [Qt] Add a Method to QWebHistory to let the browser add items to the tab's history

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 23 03:41:09 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=54739


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-02-23 03:41:09 PST ---
Attachment 82940 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/Api/qwebhistory.cpp', u'S..." exit_code: 1

Source/WebKit/qt/Api/qwebhistory.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/Api/qwebhistory.cpp:404:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list