[Webkit-unassigned] [Bug 54933] Make Editor::selectionComputedStyle return EditingStyle

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 22 18:55:49 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=54933





--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2011-02-22 18:55:49 PST ---
(From update of attachment 83262)
View in context: https://bugs.webkit.org/attachment.cgi?id=83262&action=review

>> Source/WebCore/ChangeLog:9
>> +        It also no longer takes a boolean shouldUseFixedFontDefaultSize.
> 
> I’m not sure this function needs the word computed in it any more. When the function returned a CSS style object, then it needed computed in its name because of how the same data structure is used for actual computed style and other style purposes. I think maybe selectionStartStyle would be a suitable name.

Sounds good to me.  Will rename before landing.  Thanks for the reviews!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list