[Webkit-unassigned] [Bug 54933] Make Editor::selectionComputedStyle return EditingStyle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54933


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83262|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2011-02-22 12:02:04 PST ---
(From update of attachment 83262)
View in context: https://bugs.webkit.org/attachment.cgi?id=83262&action=review

> Source/WebCore/ChangeLog:9
> +        Renamed selectionComputedStyle to selectionStartComputedStyle and changed the return type to EditingStyle.
> +        It also no longer takes a boolean shouldUseFixedFontDefaultSize.

I’m not sure this function needs the word computed in it any more. When the function returned a CSS style object, then it needed computed in its name because of how the same data structure is used for actual computed style and other style purposes. I think maybe selectionStartStyle would be a suitable name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.