[Webkit-unassigned] [Bug 54986] deprecatedEditingOffset should actually return the expected deprecated value for "after" positions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 22 17:47:55 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=54986


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |darin at apple.com,
                   |                            |eric at webkit.org
     Ever Confirmed|0                           |1




--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org>  2011-02-22 17:47:55 PST ---
(In reply to comment #7)
> The other option is to have the fast-path for legacy positions that's inlined, and a fallback that calls a private member function that does the right thing for new positions. It's still not ideal (though closer), but then again nothing is quite ideal in this mixed new/legacy position world.

That sounds reasonable.  I was going to suggest as well but I was concerned with the fact that'll result in two function calls in the slow patch.  But then lastEditingOffset already results in a bunch of function calls so that might be okay.

Eric & Darin, any opinions here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list