[Webkit-unassigned] [Bug 54986] deprecatedEditingOffset should actually return the expected deprecated value for "after" positions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54986





--- Comment #7 from Levi Weintraub <leviw at chromium.org>  2011-02-22 17:20:48 PST ---
(In reply to comment #6)
> (From update of attachment 83409 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83409&action=review
> 
> >>> Source/WebCore/dom/Position.cpp:153
> >>> +}
> >> 
> >> Why we can't keep this function inline?  I'm afraid that making this function non-inline will have some performance impact.
> > 
> > See the first comment on this bug.
> 
> I see. We can't call lastOffsetInNode(anchorNode) instead?

That won't properly handle nodes that return true for editingIgnoresContent :(

The other option is to have the fast-path for legacy positions that's inlined, and a fallback that calls a private member function that does the right thing for new positions. It's still not ideal (though closer), but then again nothing is quite ideal in this mixed new/legacy position world.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.