[Webkit-unassigned] [Bug 32510] [GTK] provide an API to control the IconDatabase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32510


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #7 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-02-21 07:54:07 PST ---
Attachment 83166 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/Web..." exit_code: 1

Source/WebKit/gtk/webkit/webkiticondatabase.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/gtk/webkit/webkiticondatabase.cpp:191:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebKit/gtk/webkit/webkiticondatabase.cpp:198:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebKit/gtk/webkit/webkiticondatabase.cpp:253:  Missing space after ,  [whitespace/comma] [3]
Source/WebKit/gtk/webkit/webkitglobals.cpp:319:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Source/WebKit/gtk/webkit/webkiticondatabase.h:26:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 6 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.